Re: [Qemu-devel] [PATCH 3/8] split away drive init from ide_init2()

[Gerd Hoffmann]

> > +void ide_init_drive(IDEState *s, DriveInfo *dinfo)
> > +{
> > +    int cylinders, heads, secs;
> > +    uint64_t nb_sectors;
> > +
> > +    if (dinfo&&  dinfo->bdrv) {
> > +        s->bs = dinfo->bdrv;
>
> Before, this assignement was executed even when !dinfo->bdrv.  Can this
> happen?

Running this once with dinfo->bdrv = something, then with dinfo->bdrv = 
NULL (which is the only case where this matters) can't happen.  You 
can't hot-unplut ide drives ;)

The code used to be called once for initialization.  Now it might be 
called twice for ide busses converted to qdev: Once with dinfo = NULL 
(when setting up the bus) and once with dinfo != NULL (when attaching 
the drive).

cheers,
  Gerd