|
From: | Anthony Liguori |
Subject: | [Qemu-devel] Re: [PATCH] virtio-console: Have a static instance of virtconsole |
Date: | Tue, 08 Sep 2009 09:08:03 -0500 |
User-agent: | Thunderbird 2.0.0.23 (X11/20090825) |
Amit Shah wrote:
Currently the VirtIOConsole struct is allocated from the call to virtio_common_init, also doing an UP_CAST implicitly. The new multiport functionality will need a few arrays and it's easier to move to the new VMState infrastructure by keeping it all within one struct. Signed-off-by: Amit Shah <address@hidden>
This seems bad. Even though the device is multiport capable, we should still supporting having multiple devices per guest.
I think Gerd would suggest this is a use-case for capabilities. I'm not sure we have a similar device that can take multiple char drivers.
Maybe we ought to treat virtio-console like a bus? Do you have any suggestions Gerd?
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |