[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] block: add bdrv_aio_flush operation
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] block: add bdrv_aio_flush operation |
Date: |
Tue, 1 Sep 2009 16:25:51 +0200 |
User-agent: |
Mutt/1.3.28i |
On Tue, Sep 01, 2009 at 01:24:02PM +0300, Avi Kivity wrote:
> Doesn't aio_flush() need to wait for all previously issued requests to
> complete?
>
> We can require callers to do that, but it seems quite a burden.
The guest does it for us when using ide/scsi/virtio, and I don't
think we want to grow other users. It's worth documenting, though.
> Patch has some tabs.
sorry, of course ;-) Writing code in the weird qemu style just takes me
three times as long as readable code, sorry. I'll fix it.