[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] mips malta: Fix fdc regression
From: |
Stefan Weil |
Subject: |
[Qemu-devel] Re: [PATCH] mips malta: Fix fdc regression |
Date: |
Fri, 28 Aug 2009 20:47:52 +0200 |
User-agent: |
Mozilla-Thunderbird 2.0.0.22 (X11/20090707) |
Stefan Weil schrieb:
> 8baf73adf664e79eae201c3f618078a220a661d9 (qdev/isa: convert fdc)
> breaks MIPS Malta:
>
> Tried to create isa device isa-fdc with no isa bus present
>
> Fix this by creating an isa bus for piix4.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> hw/piix_pci.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index c9fef92..91fd038 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -365,6 +365,7 @@ static int piix4_initfn(PCIDevice *d)
> {
> uint8_t *pci_conf;
>
> + isa_bus_new(&d->qdev);
> register_savevm("PIIX4", 0, 2, piix_save, piix_load, d);
>
> pci_conf = d->config;
>
This patch no longer is sufficient with latest QEMU
because ISA irqs also have to be defined (otherwise
the MIPS Malta emulation gets a runtime crash).
Please don't use it.
Use the new patch (mips malta: Fix fdc regression and use qdev for i8042
setup).
Regards
Stefan
Re: [Qemu-devel] [BUG] Regression for machine using fdc, Stefan Weil, 2009/08/27