[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 25/29] Add check support
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH 25/29] Add check support |
Date: |
Wed, 26 Aug 2009 23:53:17 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Luiz Capitulino <address@hidden> wrote:
> On Wed, 26 Aug 2009 21:34:20 +0200
> Juan Quintela <address@hidden> wrote:
>
>> Luiz Capitulino <address@hidden> wrote:
>> > Check is a unit testing framework for C.
>>
>> Some notes. Configuration has changed to be a bit more consistent.
>> Below I change the configuration bits to new style.
>>
>> Can I suggest that you name the configuration something different?
>>
>> CONFIG_CHECK
>>
>> means whatever, some for "check" variable in configure.
>>
>> check_suite
>> test_suite
>>
>> or anything else?
>
> CONFIG_CHECK_UTESTS or CONFIG_UTESTS will do, I think.
That works for me.
> Although it might be important to keep '--enable-check' as
> a configure option, because the library itself is called
> 'check'.
For coherence I will call it --enable-check-utests.
>> > +ifdef CONFIG_CHECK
>> > +LIBS += $(CHECK_LIBS)
>> > +endif
>>
>> We changed how to add libraries, you can remove this three lines.
>> See below where to add it.
>
> Ok, but you are talking about code in staging right?
No, we are moving everything to this style. In staging are the changes
for the other stuff in qemu.
> As I told you on IRC, I'm a bit reluctant to change a patchset based
> on upstream master to rely on something that's on staging.
This is a change that everything is suffering. No dependencies on
staging at all. The code that I showed you works today :)
>> I guess you want to add something here to tools, otherwise, you are
>> doing nothing here :)
>
> It just adds infrastructure that will be used by the following
> patches.
ah, ok. didn't looked more, sorry.
Later, Juan.
- [Qemu-devel] [PATCH 18/29] monitor: Port handler_10 to use QDict, (continued)
- [Qemu-devel] [PATCH 18/29] monitor: Port handler_10 to use QDict, Luiz Capitulino, 2009/08/26
- [Qemu-devel] [PATCH 19/29] monitor: Split monitor_handle_command(), Luiz Capitulino, 2009/08/26
- [Qemu-devel] [PATCH 20/29] monitor: Drop unused macros, Luiz Capitulino, 2009/08/26
- [Qemu-devel] [PATCH 21/29] monitor: Drop str_allocated[], Luiz Capitulino, 2009/08/26
- [Qemu-devel] [PATCH 22/29] monitor: Drop args[] handling code, Luiz Capitulino, 2009/08/26
- [Qemu-devel] [PATCH 23/29] monitor: fail when 'i' type is greater than 32-bit, Luiz Capitulino, 2009/08/26
- [Qemu-devel] [PATCH 24/29] monitor: Update supported types documentation, Luiz Capitulino, 2009/08/26
- [Qemu-devel] [PATCH 25/29] Add check support, Luiz Capitulino, 2009/08/26
- [Qemu-devel] [PATCH 26/29] Introduce QInt unit-tests, Luiz Capitulino, 2009/08/26
- [Qemu-devel] [PATCH 27/29] Introduce QString unit-tests, Luiz Capitulino, 2009/08/26
- [Qemu-devel] [PATCH 28/29] Introduce QDict test data file, Luiz Capitulino, 2009/08/26
- [Qemu-devel] [PATCH 29/29] Introduce QDict unit-tests, Luiz Capitulino, 2009/08/26
- Re: [Qemu-devel] [PATCH v2 00/29] QMonitor, Vincent Hanquez, 2009/08/28