[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 11/12] Fix detached migration with exec.
From: |
Glauber Costa |
Subject: |
[Qemu-devel] [PATCH 11/12] Fix detached migration with exec. |
Date: |
Wed, 26 Aug 2009 09:05:45 -0400 |
From: Chris Lalancette <address@hidden>
When trying to do detached migration with exec, I found that
the monitor wouldn't always return in a timely manner. I
tracked this down to exec_start_outgoing_migration. It
appeared we were setting the fd to NONBLOCK'ing, but in
point of fact we weren't.
This bugfix should also go onto the stable 0.10 branch
Signed-off-by: Chris Lalancette <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Glauber Costa <address@hidden>
---
migration-exec.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/migration-exec.c b/migration-exec.c
index ade592e..6786dbf 100644
--- a/migration-exec.c
+++ b/migration-exec.c
@@ -74,10 +74,7 @@ MigrationState *exec_start_outgoing_migration(const char
*command,
goto err_after_open;
}
- if (fcntl(s->fd, F_SETFD, O_NONBLOCK) == -1) {
- dprintf("Unable to set nonblocking mode on file descriptor\n");
- goto err_after_open;
- }
+ socket_set_nonblock(s->fd);
s->opaque = qemu_popen(f, "w");
--
1.6.2.2
- [Qemu-devel] [PATCH 01/12] fix for bad macaddr of e1000 in Windows 2003 server with original MS driver, (continued)
- [Qemu-devel] [PATCH 01/12] fix for bad macaddr of e1000 in Windows 2003 server with original MS driver, Glauber Costa, 2009/08/26
- [Qemu-devel] [PATCH 02/12] Handle BH's queued by AIO completions in qemu_aio_flush(), Glauber Costa, 2009/08/26
- [Qemu-devel] [PATCH 03/12] BACKPORT: Add save/restore support to the LSI logic SCSI device model., Glauber Costa, 2009/08/26
- [Qemu-devel] [PATCH 04/12] vmdk: Fix backing file handling, Glauber Costa, 2009/08/26
- [Qemu-devel] [PATCH 05/12] fix broken migration, Glauber Costa, 2009/08/26
- [Qemu-devel] [PATCH 06/12] fix migration to obey -S, Glauber Costa, 2009/08/26
- [Qemu-devel] [PATCH 07/12] BACKPORT: vnc: fix copyrect screen corruption, Glauber Costa, 2009/08/26
- [Qemu-devel] [PATCH 08/12] e1000.c doesn't properly emulate EERD and ICS registers, Glauber Costa, 2009/08/26
- [Qemu-devel] [PATCH 09/12] make windows notice media change, Glauber Costa, 2009/08/26
- [Qemu-devel] [PATCH 10/12] BACKPORT: Fix segfault of qemu-system-arm with PXA target, Glauber Costa, 2009/08/26
- [Qemu-devel] [PATCH 11/12] Fix detached migration with exec.,
Glauber Costa <=
- [Qemu-devel] [PATCH 12/12] Don't segfault when changing VNC password on an SDL display., Glauber Costa, 2009/08/26
- [Qemu-devel] Re: [PATCH 11/12] Fix detached migration with exec., Chris Lalancette, 2009/08/27
- [Qemu-devel] Re: [PATCH 05/12] fix broken migration, Paolo Bonzini, 2009/08/26
- Message not available
- [Qemu-devel] Re: [PATCH 05/12] fix broken migration, Glauber Costa, 2009/08/27
- [Qemu-devel] Re: [PATCH 05/12] fix broken migration, Paolo Bonzini, 2009/08/28
Re: [Qemu-devel] [GIT PULL] 0.10.7 stable release, Chris Webb, 2009/08/26
[Qemu-devel] [GIT PULL] 0.10.7 stable release, Stephen Depooter, 2009/08/26