Re: [Qemu-devel] [PATCH 3/3] qdev: convert watchdogs

[Gerd Hoffmann]

> +static void wdt_ib700_init(ISADevice *dev)
>   {
> +    timer = qemu_new_timer(vm_clock, ib700_timer_expired, NULL);
>       register_savevm("ib700_wdt", -1, 0, ib700_save, ib700_load, NULL);
> -
>       register_ioport_write(0x441, 2, 1, ib700_write_disable_reg, NULL);
>       register_ioport_write(0x443, 2, 1, ib700_write_enable_reg, NULL);
>   }

One minor nit:  Setting dev->iobase[] to { 0x441, 0x443 } here would be 
nice as 'info qtree' will show the ports actually used by the device then.

Otherwise the patch series looks good.

cheers,
  Gerd