[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 0/10] ide: cleanup and splitting.
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH 0/10] ide: cleanup and splitting. |
Date: |
Thu, 20 Aug 2009 18:39:25 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Gerd Hoffmann <address@hidden> wrote:
> Hi,
>
> Next round of the ide cleanup and splitting series. Changes:
>
> * Creating ide-internal.h is a separate patch now.
> * Comments of the new files have been fixed to actually describe
> the file content instead of being a simple cut+paste from ide.c
> * There is a new patch (last one) which moves all ide code into a
> new hw/ide/ subdirectory as suggested by avi.
Acked-by: Juan Quintela <address@hidden>
Already liked the 1st series. This one addresed all my nitpits.
Only one remained is that in the 1st patch, there are places with
whitesace/tab damage. (damage was already there).
In function ide_ioport_write()
- ide_clear_hob(ide_if);
+ ide_clear_hob(bus);
/* NOTE: data is written to the two drives */
- ide_if[0].hob_feature = ide_if[0].feature;
- ide_if[1].hob_feature = ide_if[1].feature;
- ide_if[0].feature = val;
- ide_if[1].feature = val;
+ bus->ifs[0].hob_feature = bus->ifs[0].feature;
+ bus->ifs[1].hob_feature = bus->ifs[1].feature;
+ bus->ifs[0].feature = val;
+ bus->ifs[1].feature = val;
If you have to respin the series, consider fixing it once that you are there.
Later, Juan.
- Re: [Qemu-devel] [PATCH 02/10] ide: split away ide-internal.h, (continued)
- [Qemu-devel] [PATCH 01/10] ide: add IDEBus struct, cleanups, Gerd Hoffmann, 2009/08/20
- [Qemu-devel] [PATCH 04/10] ide: split away ide-pci.c, Gerd Hoffmann, 2009/08/20
- [Qemu-devel] [PATCH 06/10] ide: split away ide-mmio.c, Gerd Hoffmann, 2009/08/20
- [Qemu-devel] [PATCH 08/10] ide: add save/restore support for isa, Gerd Hoffmann, 2009/08/20
- [Qemu-devel] [PATCH 05/10] ide: split away ide-macio.c, Gerd Hoffmann, 2009/08/20
- [Qemu-devel] [PATCH 07/10] ide: split away ide-microdrive.c, Gerd Hoffmann, 2009/08/20
- [Qemu-devel] [PATCH 10/10] ide: move code to hw/ide/, Gerd Hoffmann, 2009/08/20
- [Qemu-devel] [PATCH 09/10] ide: add save/restore support for mmio, Gerd Hoffmann, 2009/08/20
- [Qemu-devel] Re: [PATCH 0/10] ide: cleanup and splitting.,
Juan Quintela <=