Re: [Qemu-devel] [PATCH 1/6] kvm: bios: advertise pci irqs as active high

[Gleb Natapov]

On Fri, Aug 14, 2009 at 02:21:53PM +0200, Gerd Hoffmann wrote:
> From: Avi Kivity <address@hidden>
> 
> now that kvm emulates the ioapic polarity correctly, we must describe
kvm yes, but qemu doesn't. It make sense to fix qemu polarity handling
in the same series. Otherwise this patch does nothing.

> the polarity correctly in the acpi tables.  otherwise pci interrupts won't
> be delivered correctly.
> 
> Signed-off-by: Avi Kivity <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  acpi-dsdt.dsl |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/acpi-dsdt.dsl b/acpi-dsdt.dsl
> index 7bff30a..76ff100 100644
> --- a/acpi-dsdt.dsl
> +++ b/acpi-dsdt.dsl
> @@ -441,7 +441,7 @@ DefinitionBlock (
>                  Name(_HID, EISAID("PNP0C0F"))     // PCI interrupt link
>                  Name(_UID, 1)
>                  Name(_PRS, ResourceTemplate(){
> -                    IRQ (Level, ActiveLow, Shared)
> +                    IRQ (Level, ActiveHigh, Shared)
>                          {3,4,5,6,7,9,10,11,12}
>                  })
>                  Method (_STA, 0, NotSerialized)
> @@ -461,7 +461,7 @@ DefinitionBlock (
>                  {
>                      Name (PRR0, ResourceTemplate ()
>                      {
> -                        IRQ (Level, ActiveLow, Shared)
> +                        IRQ (Level, ActiveHigh, Shared)
>                              {1}
>                      })
>                      CreateWordField (PRR0, 0x01, TMP)
> @@ -488,7 +488,7 @@ DefinitionBlock (
>                  Name(_HID, EISAID("PNP0C0F"))     // PCI interrupt link
>                  Name(_UID, 2)
>                  Name(_PRS, ResourceTemplate(){
> -                    IRQ (Level, ActiveLow, Shared)
> +                    IRQ (Level, ActiveHigh, Shared)
>                          {3,4,5,6,7,9,10,11,12}
>                  })
>                  Method (_STA, 0, NotSerialized)
> @@ -508,7 +508,7 @@ DefinitionBlock (
>                  {
>                      Name (PRR0, ResourceTemplate ()
>                      {
> -                        IRQ (Level, ActiveLow, Shared)
> +                        IRQ (Level, ActiveHigh, Shared)
>                              {1}
>                      })
>                      CreateWordField (PRR0, 0x01, TMP)
> @@ -535,7 +535,7 @@ DefinitionBlock (
>                  Name(_HID, EISAID("PNP0C0F"))     // PCI interrupt link
>                  Name(_UID, 3)
>                  Name(_PRS, ResourceTemplate(){
> -                    IRQ (Level, ActiveLow, Shared)
> +                    IRQ (Level, ActiveHigh, Shared)
>                          {3,4,5,6,7,9,10,11,12}
>                  })
>                  Method (_STA, 0, NotSerialized)
> @@ -555,7 +555,7 @@ DefinitionBlock (
>                  {
>                      Name (PRR0, ResourceTemplate ()
>                      {
> -                        IRQ (Level, ActiveLow, Shared)
> +                        IRQ (Level, ActiveHigh, Shared)
>                              {1}
>                      })
>                      CreateWordField (PRR0, 0x01, TMP)
> @@ -582,7 +582,7 @@ DefinitionBlock (
>                  Name(_HID, EISAID("PNP0C0F"))     // PCI interrupt link
>                  Name(_UID, 4)
>                  Name(_PRS, ResourceTemplate(){
> -                    IRQ (Level, ActiveLow, Shared)
> +                    IRQ (Level, ActiveHigh, Shared)
>                          {3,4,5,6,7,9,10,11,12}
>                  })
>                  Method (_STA, 0, NotSerialized)
> @@ -602,7 +602,7 @@ DefinitionBlock (
>                  {
>                      Name (PRR0, ResourceTemplate ()
>                      {
> -                        IRQ (Level, ActiveLow, Shared)
> +                        IRQ (Level, ActiveHigh, Shared)
>                              {1}
>                      })
>                      CreateWordField (PRR0, 0x01, TMP)
> -- 
> 1.6.2.5
> 
> 

--
                        Gleb.