Re: [Qemu-devel] RE: 971c47c - Do not use $SHELL to invoke our scripts

[malc]

On Wed, 12 Aug 2009, Jordan Justen wrote:

> On Wed, Aug 12, 2009 at 7:03 PM, malc<address@hidden> wrote:
> > On Wed, 12 Aug 2009, Jordan Justen wrote:
> >
> >> Regarding commit 971c47c, this causes a build error for me on Ubuntu
> >> 9.04.  I think this might be because Ubuntu/Debian have moved /bin/sh
> >> from bash to dash.  The build is okay if I change the first line of
> >> configure from /bin/sh to /bin/bash.  Should configure point directly
> >> at bash?
> >
> > Please be more specific, what is the error? And FWIW i mainly use ash
> > to run QEMUs configure (and dash is derived from ash as far as i can
> > tell)
> 
> It seems to only be an issue with dash if I run it as './configure'.
> 'dash configure' is okay.
> 
> With /bin/sh -> bash, if I insert an 'echo $_' before this line in configure:
> THISSHELL=${_:-/bin/sh}
> then $_ is blank.
> 
> With /bin/sh -> dash, 'echo $_' just before that line will show $_ to
> be './configure'.  Therefore THISSHELL becomes './configure', which is
> obviously invalid.
> 
> I'm not sure of a fix yet...

Thanks for analysis, i've pushed the "fix" hopefully it would finally put
an end to this.

-- 
mailto:address@hidden