[Qemu-devel] Re: [Qemu-commits] [COMMIT 0bd8246] vga: do not resize the screen on hw_invalidate

[Stefano Stabellini]

On Tue, 11 Aug 2009, Avi Kivity wrote:
> On 08/11/2009 04:39 PM, Stefano Stabellini wrote:
> > On Tue, 11 Aug 2009, Avi Kivity wrote:
> >    
> >> On 08/11/2009 04:20 PM, Stefano Stabellini wrote:
> >>      
> >>> is the screendump taken using a vnc screendump utility or is it done by
> >>> issuing the screendump command from the monitor?
> >>>
> >>>        
> >> The screendump command from the monitor.
> >>
> >>      
> >
> > Then you must also have at least a vnc client always connected to vnc,
> > right?
> > Because in the trace you posted before there is a call from vnc_refresh,
> > and that should happen only when there are vnc clients connected.
> >    
> 
> I observed this even without a vnc client connected (kvm-autotest + lunch).
> 

If a vnc client is connected and a resize event happens while we are
taking a screendump, we loose the resize event in vnc and we end up with
a DisplaySurface of the wrong size.

The same thing could happen without vnc client connected because we are
not handling resize events in the screen_dump code at all.

I am going to take Anthony suggestion and refactor the screen_dump code
to use the DisplayState interface properly.