Re: [Qemu-devel] [PATCH] Migration via unix sockets.

[Daniel P. Berrange]

On Tue, Aug 11, 2009 at 11:15:59AM +0200, Chris Lalancette wrote:
> +static void fd_accept_incoming_migration(void *opaque)
> +{
> +    struct sockaddr addr;
> +    socklen_t addrlen = sizeof(addr);
> +    int s = (unsigned long)opaque;
> +    QEMUFile *f;
> +    int c, ret;
> +
> +    do {
> +        c = accept(s, &addr, &addrlen);
> +    } while (c == -1 && socket_error() == EINTR);

This bit doesn't make sense if we're just passing an open FD, since
it may not be a socket. Just declare that if passing a socket FD,
the FD must be a pre-accepted client, and remove this line.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|