[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type |
Date: |
Thu, 30 Jul 2009 16:19:44 +0100 |
User-agent: |
KMail/1.11.4 (Linux/2.6.29-2-amd64; KDE/4.2.4; x86_64; ; ) |
On Thursday 30 July 2009, Avi Kivity wrote:
> On 07/30/2009 06:04 PM, Filip Navara wrote:
> > Again, intptr_t should be used here in long term. long is probably
> > fine for now before I post the Win64 patches.
>
> No, for the long term we shouldn't be putting pointers into integers or
> vice versa unless there's a really good reason to do so.
I'd go further than that. Don't put integers into pointers *at all*. It's
really not worth it. Use a proper union/struct/opaque-pointer-to-value.
Paul
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, (continued)
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Luiz Capitulino, 2009/07/29
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Avi Kivity, 2009/07/29
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Luiz Capitulino, 2009/07/29
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Avi Kivity, 2009/07/29
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Luiz Capitulino, 2009/07/30
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Avi Kivity, 2009/07/30
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Luiz Capitulino, 2009/07/30
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Filip Navara, 2009/07/30
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Avi Kivity, 2009/07/30
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Filip Navara, 2009/07/30
- Re: [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type,
Paul Brook <=
[Qemu-devel] [PATCH 02/25] net: Fix do_set_link() return type, Luiz Capitulino, 2009/07/28
[Qemu-devel] [PATCH 03/25] Add wrappers to functions used by the Monitor, Luiz Capitulino, 2009/07/28
[Qemu-devel] [PATCH 04/25] monitor: Document missing supported argument types, Luiz Capitulino, 2009/07/28
[Qemu-devel] [PATCH 05/25] monitor: New format for handlers argument types, Luiz Capitulino, 2009/07/28
[Qemu-devel] [PATCH 06/25] monitor: Setup a dictionary with handler arguments, Luiz Capitulino, 2009/07/28
[Qemu-devel] [PATCH 07/25] monitor: Export qemu-dict.h header, Luiz Capitulino, 2009/07/28
[Qemu-devel] [PATCH 08/25] monitor: New GET_TLONG and GET_TPHYSADDR macros, Luiz Capitulino, 2009/07/28
[Qemu-devel] [PATCH 09/25] monitor: Port handler_0 to use the dictionary, Luiz Capitulino, 2009/07/28
[Qemu-devel] [PATCH 10/25] monitor: Port handler_1 to use the dictionary, Luiz Capitulino, 2009/07/28
[Qemu-devel] [PATCH 11/25] monitor: Port handler_2 to use the dictionary, Luiz Capitulino, 2009/07/28