[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 07/14] Code motion; make mm VGA init function mo
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 07/14] Code motion; make mm VGA init function more like standard vga init function. Add missing vga_reset hook to vga_mm_init. |
Date: |
Thu, 30 Jul 2009 13:03:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Zachary Amsden wrote:
> Signed-off-by: Zachary Amsden <address@hidden>
> ---
> hw/vga.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/hw/vga.c b/hw/vga.c
> index 33645a0..9b50959 100644
> --- a/hw/vga.c
> +++ b/hw/vga.c
> @@ -2422,14 +2422,17 @@ static void vga_mm_init(VGAState *s,
> target_phys_addr_t vram_base,
> {
> int s_ioport_ctrl, vga_io_memory;
>
> + qemu_register_reset(vga_reset, 0, s);
vga users like cirrus or vmware invoke reset too. You probably want to
drop those calls now. And did you check that vga_reset is still always
invoked before any vga user reset callback?
> + register_savevm("vga", 0, 2, vga_save, vga_load, s);
> +
> + s->bank_offset = 0;
> +
> s->it_shift = it_shift;
> s_ioport_ctrl = cpu_register_io_memory(vga_mm_read_ctrl,
> vga_mm_write_ctrl, s);
> - vga_io_memory = cpu_register_io_memory(vga_mem_read, vga_mem_write, s);
>
> - register_savevm("vga", 0, 2, vga_save, vga_load, s);
> + vga_io_memory = cpu_register_io_memory(vga_mem_read, vga_mem_write, s);
>
> cpu_register_physical_memory(ctrl_base, 0x100000, s_ioport_ctrl);
> - s->bank_offset = 0;
> cpu_register_physical_memory(vram_base + 0x000a0000, 0x20000,
> vga_io_memory);
> qemu_register_coalesced_mmio(vram_base + 0x000a0000, 0x20000);
> }
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
- [Qemu-devel] [PATCH 05/14] Change cpu_phys mem callback to use [offset, size) bounds instead of [start, end)., (continued)
- [Qemu-devel] [PATCH 05/14] Change cpu_phys mem callback to use [offset, size) bounds instead of [start, end)., Zachary Amsden, 2009/07/30
- [Qemu-devel] [PATCH 06/14] Split VGA ioport init into a helper function., Zachary Amsden, 2009/07/30
- [Qemu-devel] [PATCH 07/14] Code motion; make mm VGA init function more like standard vga init function. Add missing vga_reset hook to vga_mm_init., Zachary Amsden, 2009/07/30
- [Qemu-devel] [PATCH 08/14] Make VGA vram offset passed into vga_mm_init absolute. Since this is a function of the platform, it makes sense to have it be explicitly known in the platform layer rather than hardcoded inside the vga code., Zachary Amsden, 2009/07/30
- [Qemu-devel] [PATCH 09/14] Further transformation: use common vga_init() which allows either I/O port or memory mapped based control., Zachary Amsden, 2009/07/30
- [Qemu-devel] [PATCH 10/14] Stash VGA physical address and use it in KVM callbacks. Stash VGA physical pointer in cirrus vga as well., Zachary Amsden, 2009/07/30
- [Qemu-devel] [PATCH 11/14] Add some defined constants for VGA offsets., Zachary Amsden, 2009/07/30
- [Qemu-devel] [PATCH 12/14] Add a PCI BAR for the VGA ROM which is mapped into cirrus_vga. This makes the cirrus device complete under some X servers which require the V_BIOS mapping., Zachary Amsden, 2009/07/30
- [Qemu-devel] [PATCH 13/14] Allow cirrus VGA to be initialized multiple times; only the first init takes the ISA memory region and hardware I/O ports., Zachary Amsden, 2009/07/30
- [Qemu-devel] [PATCH 14/14] Atrocious and horrendous patch to demonstrate multiple SDL displays. The multiple SDL displays can be seen on one console, using ctrl-alt-1/2 to switch between them., Zachary Amsden, 2009/07/30
- [Qemu-devel] Re: [PATCH 07/14] Code motion; make mm VGA init function more like standard vga init function. Add missing vga_reset hook to vga_mm_init.,
Jan Kiszka <=
- [Qemu-devel] Re: [PATCH 05/14] Change cpu_phys mem callback to use [offset, size) bounds instead of [start, end)., Jan Kiszka, 2009/07/30
Re: [Qemu-devel] Various VGA / VNC fixes and cleanups to prep for multiheaded graphics, Daniel P. Berrange, 2009/07/30