qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 19/25] monitor: Split monitor_handle_command()


From: Luiz Capitulino
Subject: [Qemu-devel] Re: [PATCH 19/25] monitor: Split monitor_handle_command()
Date: Wed, 29 Jul 2009 12:44:41 -0300

On Wed, 29 Jul 2009 17:31:54 +0200
Paolo Bonzini <address@hidden> wrote:

> 
> > +    if (cmd) {
> > +        void (*handler)(Monitor *mon, const struct qemu_dict *qdict);
> > +        handler = cmd->handler;
> > +        handler(mon, qdict);
> > +    }
> 
> I'd prefer cmd->handler(mon, qdict).  One less place to change if you 
> change the arguments later.

 Yes, but this will be improved later, because info() handlers also
use struct mon_cmd_t. This change is a bit beyond this patchset's
goal.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]