[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 19/25] monitor: Split monitor_handle_command()
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH 19/25] monitor: Split monitor_handle_command() |
Date: |
Wed, 29 Jul 2009 12:44:41 -0300 |
On Wed, 29 Jul 2009 17:31:54 +0200
Paolo Bonzini <address@hidden> wrote:
>
> > + if (cmd) {
> > + void (*handler)(Monitor *mon, const struct qemu_dict *qdict);
> > + handler = cmd->handler;
> > + handler(mon, qdict);
> > + }
>
> I'd prefer cmd->handler(mon, qdict). One less place to change if you
> change the arguments later.
Yes, but this will be improved later, because info() handlers also
use struct mon_cmd_t. This change is a bit beyond this patchset's
goal.
- [Qemu-devel] [PATCH 11/25] monitor: Port handler_2 to use the dictionary, (continued)
- [Qemu-devel] [PATCH 11/25] monitor: Port handler_2 to use the dictionary, Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 13/25] monitor: Port handler_4 to use the dictionary, Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 12/25] monitor: Port handler_3 to use the dictionary, Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 14/25] monitor: Port handler_5 to use the dictionary, Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 15/25] monitor: Port handler_6 to use the dictionary, Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 16/25] monitor: Port handler_7 to use the dictionary, Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 17/25] monitor: Drop handler_8 and handler_9 handling, Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 18/25] monitor: Port handler_10 to use the dictionary, Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 19/25] monitor: Split monitor_handle_command(), Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 20/25] monitor: Add a new index for str_allocated[], Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 21/25] monitor: Drop args[] from monitor_parse_command(), Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 22/25] monitor: Drop 'nb_args' from monitor_parse_command(), Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 23/25] Add check support, Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 25/25] Introduce qemu-dict unit-tests, Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 24/25] Introduce dictionary test data file, Luiz Capitulino, 2009/07/28