[Qemu-devel] Re: [PATCH 3/4] Use C99 initializers for audio_option

[malc]

On Tue, 28 Jul 2009, Juan Quintela wrote:

> malc <address@hidden> wrote:
> > On Mon, 27 Jul 2009, Juan Quintela wrote:
> >
> > I'd prefer:
> >
> >        { .name  = "DAC_SIZE_IN_USEC",
> >          .tag   = AUD_OPT_BOOL,
> >          .valp  = &conf.size_in_usec_out,
> >          .descr = "DAC period/buffer size in microseconds (otherwise in 
> > frames)" },
> >        { ...
> >
> > And likewise elsewhere.
> 
> I tried to be consistent with the qdev patches, they add all its "arrays
> of structures" this way (it is one of the bigger users of the feature
> that I saw).

Let's look at original example:

+    {
+        .name = "DAC_SIZE_IN_USEC",
+        .tag = AUD_OPT_BOOL,
+        .valp = &conf.size_in_usec_out,
+        .descr = "DAC period/buffer size in microseconds (otherwise in frames)"
+    },{

It's internally inconsistent (begins with a bsd style ends with k&r,
and on top of that without space after comma). Should either be done
the way i mentioned earlier or with:

{
  ...
},
{
}

And i much prefer the former.

-- 
mailto:address@hidden