Re: [Qemu-devel] [PATCH, RFC] Sparc64: convert APB to qdev

[Jason Wessel]

Blue Swirl wrote:
> On Tue, Jul 21, 2009 at 12:19 AM, Igor
> Kovalenko<address@hidden> wrote:
>   
>> On Mon, Jul 20, 2009 at 2:26 PM, Blue Swirl<address@hidden> wrote:
>>     
>>> I have a problem with APB conversion to qdev. For some reason, with
>>> the patch applied, PCI config register access changes and OpenBIOS
>>> can't find any PCI devices.
>>>       
>> You are using pci_host_data_* which expects opaque pointer to PCIHostState,
>> so you need to pass appropriate opaque to cpu_register_io_memory.
>> With this small amendment I verified there are no changes to qemu.log and
>> serial console output.
>>     
>
> Great, thanks!
>
>   
>> Not sure if this requires sign-off :)
>>     
>
> Good question, perhaps the SoB experts should clarify the policy.
>
> But in this case it makes no sense to commit my broken version and
> then your patch. I think I'll just give you credit in the message for
> the fixed commit.
>
>   

If you are looking for some kind of standard to follow based on the
linux kernel use, the document is:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;hb=HEAD

The example given shows a maintainer cleaning up someone else's patch
for merge.

347
<http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=5c555a8b39e553cf0c3117026ebf37d481c588b6;hb=HEAD#l347>
        Signed-off-by: Random J Developer <address@hidden>
348
<http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=5c555a8b39e553cf0c3117026ebf37d481c588b6;hb=HEAD#l348>
        address@hidden: struct foo moved from foo.c to foo.h]
349
<http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=5c555a8b39e553cf0c3117026ebf37d481c588b6;hb=HEAD#l349>
        Signed-off-by: Lucky K Maintainer <address@hidden>

The pattern is no different if you fold 1 or more patches together.  The
credit can go in the bracket section.

Akpm does this a lot if you wanted to search the linux kernel for any
other examples.
linux-2.6.git % git log |grep "\[akpm" |wc -l
1276


Cheers,
Jason.