Re: [Qemu-devel] [PATCH 1/4] Move mp_state to CPU_COMMON

[Alexander Graf]

On 27.07.2009, at 15:51, Anthony Liguori wrote:

> Alexander Graf wrote:
> > MP State is implemented in the generic code, so let's move the  
> > variable
> > it accesses to generic code as well.
> >
> > Unbreaks PPC w/ KVM.
>
> And breaks the build for everyone else.
>
> You change mp_state from a uint32_t to a int, but then there's:
>
> target-i386/machine.c:
>
>   qemu_put_be32s(f, &env->mp_state);
>
> Which expects a uint32_t.

Oh right - -Werror. I have to disable that on every machine I was on  
so far because it always breaks somewhere.

Want to do the one-liner change yourself or would you like me to send  
a new patch?

Alex