[Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG

[Jan Kiszka]

Alexander Graf wrote:
> 
> Am 22.07.2009 um 23:15 schrieb Anthony Liguori <address@hidden>:
> 
>> Alexander Graf wrote:
>>>
>>> The only thing I'd agree with as a good idea instead of the version I
>>> sent is an explicit switch statement with an include of errno.h with
>>> __KERNEL__ set.
>>
>> No way :-)
>>
>> What's the problem with fixing the kernel to return a proper errno?
> 
> I'd rather do a proper dirty log implementation than that :). But yes,
> you convinced me. I'll just do dirtylogging for ppc.

Puh... :)

> 
> Now what about ia64?

There is a non-empty kvm_vm_ioctl_get_dirty_log() in kvm-ia64.c.

So I think we can revert your patch and just merge the tiny error-check
fix, right?

Jan

signature.asc
Description: OpenPGP digital signature