[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 3/7] Add mp_state to PPC CPU struct
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 3/7] Add mp_state to PPC CPU struct |
Date: |
Wed, 22 Jul 2009 18:51:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Hollis Blanchard wrote:
> On Wed, 2009-07-22 at 11:22 -0500, Anthony Liguori wrote:
>> Hollis Blanchard wrote:
>>> On Wed, 2009-07-22 at 10:34 -0500, Anthony Liguori wrote:
>>>
>>>> Alexander Graf wrote:
>>>>
>>>>> Some generic code tries to access env->mp_state. Let's just make
>>>>> it happy and provide it.
>>>>>
>>>>> Signed-off-by: Alexander Graf <address@hidden>
>>>>>
>>>>>
>>>> Or we can move that code from kvm-all.c to target-i386/kvm.c where it
>>>> belongs :-)
>>>>
>>> Common code uses mp_state, and i386 is the only thing calling that code.
>>> However, the ioctl used by that code is valid for all architectures; it
>>> will just return -EINVAL. Someday we might need it in common code, but
>>> then again it's not even clear to me it will be useful outside of x86.
>>>
>>> I'm fine with moving it too, as long as it's also renamed at the same
>>> time. :)
>>>
>> Why is it a common ioctl instead of an arch specific ioctl?
>
> I can only speculate: Marcelo probably thought other architectures may
> have something useful to put there.
>
mp_state is also used by (yet unsupported) ia64. So I think it's better
to keep the related bits in the arch-independent part.
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
- [Qemu-devel] Re: [PATCH 6/7] Set slots more carefully, (continued)
- [Qemu-devel] Re: [PATCH 6/7] Set slots more carefully, Jan Kiszka, 2009/07/17
- [Qemu-devel] Re: [PATCH 6/7] Set slots more carefully, Alexander Graf, 2009/07/17
- [Qemu-devel] Re: [PATCH 6/7] Set slots more carefully, Jan Kiszka, 2009/07/17
- [Qemu-devel] Re: [PATCH 6/7] Set slots more carefully, Alexander Graf, 2009/07/17
- [Qemu-devel] Re: [PATCH 6/7] Set slots more carefully, Jan Kiszka, 2009/07/17
- Re: [Qemu-devel] [PATCH 6/7] Set slots more carefully, Anthony Liguori, 2009/07/21
- Re: [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct, Anthony Liguori, 2009/07/22
- Re: [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct, Hollis Blanchard, 2009/07/22
- Re: [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct, Anthony Liguori, 2009/07/22
- Re: [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct, Hollis Blanchard, 2009/07/22
- [Qemu-devel] Re: [PATCH 3/7] Add mp_state to PPC CPU struct,
Jan Kiszka <=
- [Qemu-devel] Re: [PATCH 3/7] Add mp_state to PPC CPU struct, Anthony Liguori, 2009/07/22
- [Qemu-devel] Re: [PATCH 3/7] Add mp_state to PPC CPU struct, Jan Kiszka, 2009/07/22
[Qemu-devel] Re: [PATCH 0/4] Add preliminary KVM support for non-embedded PPC v3, Hollis Blanchard, 2009/07/21