[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/13] qdev: rework device properties.
|
From: |
Paul Brook |
|
Subject: |
Re: [Qemu-devel] [PATCH 01/13] qdev: rework device properties. |
|
Date: |
Fri, 10 Jul 2009 18:13:36 +0100 |
|
User-agent: |
KMail/1.11.4 (Linux/2.6.29-2-amd64; KDE/4.2.4; x86_64; ; ) |
>+extern PropertyInfo qdev_prop_uint32;
>+extern PropertyInfo qdev_prop_hex32;
Having both of these seems wrong.
>+ .name = "fifo-size",
>+ .info = &qdev_prop_uint32,
>+ .offset = offsetof(SyborgPointerState, fifo_size),
>+ .defval = (uint32_t[]) { 16 },
This feels kinda crufty. Very easy to get the wrong types. There's also no
typechecking in qdev_set_prop*.
>+int qdev_prop_set_uint32(DeviceState *dev, const char *name, uint32_t
> value);
Why does this return a value?
Paul
- Re: [Qemu-devel] [PATCH 04/13] qdev: add generic qdev_device_add(), (continued)
- [Qemu-devel] [PATCH 02/13] qdev: factor out driver search to qdev_find_info(), Gerd Hoffmann, 2009/07/10
- [Qemu-devel] [PATCH 03/13] qdev/pci: make pci_create return DeviceState instead of PCIDevice., Gerd Hoffmann, 2009/07/10
- [Qemu-devel] [PATCH 06/13] qdev: add no_user, alias and desc, Gerd Hoffmann, 2009/07/10
- [Qemu-devel] [PATCH 07/13] qdev: es1370 description, Gerd Hoffmann, 2009/07/10
- [Qemu-devel] [PATCH 08/13] qdev: convert all vga, Gerd Hoffmann, 2009/07/10
- [Qemu-devel] [PATCH 13/13] qdev: print device id in "info pci"., Gerd Hoffmann, 2009/07/10
- [Qemu-devel] [PATCH 09/13] qdev/pci: hook up i440fx., Gerd Hoffmann, 2009/07/10
- [Qemu-devel] [PATCH 01/13] qdev: rework device properties., Gerd Hoffmann, 2009/07/10
- Re: [Qemu-devel] [PATCH 01/13] qdev: rework device properties.,
Paul Brook <=
[Qemu-devel] [PATCH 10/13] qdev: add user-specified identifier to devices., Gerd Hoffmann, 2009/07/10
[Qemu-devel] [PATCH 12/13] qdev: add id= support for pci nics., Gerd Hoffmann, 2009/07/10
[Qemu-devel] [PATCH 05/13] qdev: add -device command line option., Gerd Hoffmann, 2009/07/10
[Qemu-devel] [PATCH 11/13] switch balloon initialization to -device., Gerd Hoffmann, 2009/07/10