[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] sanitize ->bdrv_get_buffer / ->bdrv_put_buffer
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] sanitize ->bdrv_get_buffer / ->bdrv_put_buffer calling conventions |
Date: |
Wed, 08 Jul 2009 15:46:15 +0200 |
User-agent: |
Thunderbird 2.0.0.21 (X11/20090320) |
Christoph Hellwig schrieb:
> The VM state offset is an concept internal to the image format, it
> doesn't even have to be a traditional linear offset. So change the
> ->bdrv_get_buffer / ->bdrv_put_buffer calling convention to always pass
> a relative offset and add the VM state offset to it internally inside
> the qcow2 code.
Looks good to me and makes the interface nicer. Maybe we could use the
opportunity to change the function names to something like
bdrv_vmstate_read/write? get/put_buffer is quite unspecific, it could
mean anything.
Kevin