[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] ATAPI pass through v2: update the configure
From: |
Bique Alexandre |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] ATAPI pass through v2: update the configure |
Date: |
Mon, 6 Jul 2009 15:33:12 +0100 |
User-agent: |
KMail/1.11.4 (Linux/2.6.30-ARCH; KDE/4.2.4; x86_64; ; ) |
On Monday 06 July 2009 14:55:00 Christoph Hellwig wrote:
> On Mon, Jul 06, 2009 at 02:47:40PM +0100, Bique Alexandre wrote:
> > On Sunday 05 July 2009 09:16:37 Christoph Hellwig wrote:
> > > On Wed, Jul 01, 2009 at 07:32:04PM +0100, Bique Alexandre wrote:
> > > > This patch update the configure by adding --enable-atapi-pt and
> > > > --disable-atapi-pt.
> > >
> > > Do we need an option for this? I'd say we should make it uncoditional
> > > when built on Linux like the SCSI passthrough code.
> >
> > Ok, so I just do:
> >
> > If Linux then
> > enable
> > else
> > disable
> > fi
>
> Yes. Take a look at hw/virtio-blk.c and hw/scsi-generic.c for how we
> guard the other pass-through users.
I looked at these files and instead of doing
#ifdef __linux__
... code ...
#endif
I propose to do
#ifdef __linux__
# define CONFIG_ATAPI_PT
#endif
in config.h and still do
#ifdef CONFIG_ATAPI_PT
... code ...
#endif
in other source file.
Here is an updated patch.
Thanks.
--
Alexandre Bique
configure-atapi
Description: Text Data