[Qemu-devel] Re: [RfC PATCH] qdev: rework device properties.

[Gerd Hoffmann]

On 06/30/09 16:03, Juan Quintela wrote:
> Gerd Hoffmann<address@hidden>  wrote:
> > Early RfC patch.  Not functional yet.  Just for comments right now.
> >
> > Overall plan:
> >   * drop property lists. The properties are saved directly in the
> >     device state structs instead.
> >   * drop qdev_get_prop* functions, not needed any more.
> >   * replace qdev_set_prop* functions by qdev_prop_{parse,set*}.
> >
> > Done:
> >   * added code to handle properties.
> >
> > Todo:
> >   * convert all the device drivers.
> >   * actually drop the old functions.
>
> Any good reason why you remove the list of propierties?

Pointless indirection and extra storage.
Note that this doesn't mean properties itself go away.

> a- a way to defino an alias, that "mouse" is equivalent to "QEMU USB
>     Keyboard".  One is the qdev name and the other is the name passed to
>     --usbdevice name.

stick an alias next to name in DeviceInfo?
I don't see why this should use properties.

> b- things like disk are composed of:
>     "disk" : "rest of disk arguments"

No.  You'll create the host state from most of "rest of disk arguments". 
 You'll attach a name property to qdev so the driver has a handle to 
lookup the host side of things.

cheers,
  Gerd