Re: [Qemu-devel] [RFC PATCH] qdev: add -pcidevice command line option.

[Anthony Liguori]

Gerd Hoffmann wrote:
> Ok, lets start to collect some low-hanging fruit we can get from the
> qdev bits even at the current early state.
>
> ==> stop adding cmd line switches for each and every device <==
> ==>        do funky stuff you could not do before           <==
>
> Here is a patch adding a generic -pcidevice command line switch.  Works
> only for qdev-converted devices.  Works (for now) only for devices which
> don't need configuration (i.e. nics don't work or maybe use vlan0
> unconditionally).  Most useful with my qdev patch queue applied.
>
> Examples:
>
>   -pcidevice ES1370,addr=42        (replaces -audio es1370).
>   -pcidevice virtio-balloon-pci    (replaces -balloon).
>   -pcidevice lsi53c895a,addr=23    (add scsi adapter in specified slot).
>   -pcidevice "PIIX3 USB-UHCI"      (add second usb bus).
>
> Comments?
>   
You read my mind :-)

I was just thinking about this as I was looking over staging.

What I would like to see is that this internal mechanism be used to 
implement the switches it replaces.  That is, -balloon should just add 
just be a convenience option that expands to -pcidevice.  The same for 
-audio.

Regards,

Anthony Liguori