qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/10] qdev patches.


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 0/10] qdev patches.
Date: Fri, 26 Jun 2009 23:16:55 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux)

Paul Brook <address@hidden> writes:

>> The other patches switch over various drivers and busses to qdev.  They
>> depend on the first two patches.  The conversion work is far from being
>> completed.  Currently my main focus is on getting all devices into the
>> qdev tree.  Most drivers are not (yet) in a state where creating them
>> from a fdt can actually work though.  IMHO the patches are useful
>> nevertheless.  YMMV, feel free to cherry-pick some of the patches only.
>
> I'm not so convinced. I don't see much value in "dummy" conversion that still 
> requires use of the old APIs to create devices.

What's wrong with merging an intermediate step, as long as it doesn't
break anything, clearly moves in the right direction, and the developer
can be trusted to go the rest of the way?

Forcing him to keep his substantial patches out of tree until they're
perfectly complete just creates merging & rebasing hassle for him, which
can only slow him down.  Moreover, it keeps his work less visible, and
thus risks duplicated effort.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]