Re: [Qemu-devel] Re: [PATCH 01/11] QMP: Introduce specification file

[Luiz Capitulino]

On Tue, 23 Jun 2009 08:12:33 -0500
Anthony Liguori <address@hidden> wrote:

> The specification looks pretty good.

 Thanks, used previous discussions as my main reference.

> >> +
> >> +3.3.1 Server Greeting
> >> +---------------------
> >> +
> >> +Sent when a new connection is opened.
> >> +
> >> +Format: + OK QEMU<version>  QMP<version>
> >> +Example: + OK QEMU 0.10.50 QMP 0.1
> >>    
> >
> > Clients should never make decisions based on the qemu or qmp version.  
> > Rather, we should provide a facility to query the availability of 
> > features.
> 
> I agree, but I'd suggest leaving the QMP version in there for insurance 
> purposes in case we really screw up and need to bump the version.  In 
> fact, having the client also negotiate the QMP version isn't a bad idea.

 Will keep.

> >> + o Command completion failed
> >> +
> >> +    Format: - ERR<reason>
> >> +    Example: - ERR could not find network device 'foo'
> >> +
> >>    
> >
> > Maybe add a numeric error code (to be defined by individual commands).
> 
> I think copying HTTP makes sense here.

 Ok, as I said in others emails I was a bit agains't it but have
changed my mind after three being in favor. :)

> How would asynchronous commands work?  Could you give an example of 
> doing live migration through QMP?

 Avi has already explained this part. To be honest, I didn't have this
clear in my mind, but Avi's suggestion is what makes sense to me.