[Qemu-devel] Re: [PATCH 06/11] QMP: Introduce asynchronous events infrastructure

[Jan Kiszka]

Luiz Capitulino wrote:
> It is just an exported function that will be used by other subsystems
> to print specific events to the output buffer.
> 
> This is based in ideas by Amit Shah <address@hidden>.
> 
> Signed-off-by: Luiz Capitulino <address@hidden>
> ---
>  monitor.c   |   18 ++++++++++++++++++
>  monitor.h   |    6 ++++++
>  qemu-tool.c |    4 ++++
>  3 files changed, 28 insertions(+), 0 deletions(-)
> 
> diff --git a/monitor.c b/monitor.c
> index 462f60b..df58bdd 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -266,6 +266,24 @@ void monitor_printf_data(Monitor *mon, const char *fmt, 
> ...)
>      va_end(ap);
>  }
>  
> +/* Asynchronous events main function */
> +void monitor_notify_event(MonitorEvent event)
> +{
> +    if (!monitor_ctrl_mode(cur_mon))
> +        return;
> +
> +    assert(event < EVENT_MAX);
> +    monitor_puts(cur_mon, "* EVENT ");
> +
> +    switch (event) {
> +    case EVENT_MAX:
> +        // Avoid gcc warning, will never get here
> +        break;
> +    }
> +
> +    monitor_puts(cur_mon, "\n");
> +}
> +

You shouldn't use cur_mon here. It's for legacy code that still assumes
there can be only one monitor terminal. Instead, iterate over all
monitors and distribute the event to those that are in control mode.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux