qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC


From: Jamie Lokier
Subject: Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC
Date: Sun, 21 Jun 2009 00:25:08 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

François Revol wrote:
> > On 06/20/2009 05:31 PM, Anthony Liguori wrote:
> > > Please include a Signed-off-by line and use C-style comments
> > > instead
> > > of C++ style comments.  Otherwise, looks good.
> >
> > What do we have against C++ style comments?
> 
> They are not valid in C code :P

Wrong.

Valid in GNU C for about 14 years, and ANSI/ISO C for about 10 years...

I'll be surprised if any C compiler used on any open source operating
system, or any major commercial C compiler, doesn't accept them.

Of course I still forbid them in my code too - they look wrong :-)

-- Jamie




reply via email to

[Prev in Thread] Current Thread [Next in Thread]