Re: [Qemu-devel] [PATCH v4] avoid compilation warning/errors on up to date

[Luiz Capitulino]

On Thu, 18 Jun 2009 01:16:37 +0200
"Jean-Christophe Dubois" <address@hidden> wrote:

> And whatever I have added is a lot more robust than what was before.
> Once again, please just show me where my patch is incorrect and I
> will fix it. 

 I really missed this v4, sorry for that and thanks for letting me know.

 I think the first step is to do one logical change at a time. You
could, for example do:

 1. Add qemu_read() and qemu_write()
 2. Port one subsystem per-patch for each of them

 Each lseek() or ftruncate() could also be done this way. Unrelated
fixes should be in different patches.

 We also have to define how far we're going on this 'warning fixing'
thing. read() and write() seems ok to me, now close() doesn't seem
important.

 This is my personal suggestion on the topic, it doesn't represent
upstream's view though.

 Also, I think qemu_read() and qemu_write() should abort on error,
if that's what callers are going to do.