Re: [Qemu-devel] [PATCH] replace duplicated code.

[Gerd Hoffmann]

On 06/18/09 15:59, Glauber Costa wrote:
> > You have changed the ordering of the qdev_set_netdev and qdev_init
> > calls.  I don't think this is correct, the init callback will not see
> > the nicinfo then.
> I see.
>
> How would you feel about changing the nd field of qdev for a void * one,
> call it private, or whatever?
>
> then we could have a generic qdev_set_private(dev, p), that does it for
> everybody. I must say I kinda dislike that specific dependency on nd for
> net devices. Ideally, all devices should be treated as the same.

What problem you are trying to solve?
Unless there is something urgent to fix I'd leave it as is for now.

We need some sane way to link guest config (hopefully done by config 
file soon) to host config.  Link nic to vlan in that case, but disks and 
chardevs share the same issue.  I consider DeviceState->nd being 
temporary and expect will go away once we figured that out.  It is a 
bigger undertaking though ...

cheers,
  Gerd