[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] mingw: Do not perform string format checks
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH] mingw: Do not perform string format checks |
Date: |
Tue, 16 Jun 2009 00:43:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Johannes Schindelin wrote:
> Hi,
>
> On Mon, 15 Jun 2009, Jan Kiszka wrote:
>
>> Johannes Schindelin wrote:
>>> Hi,
>>>
>>> On Sun, 14 Jun 2009, Jan Kiszka wrote:
>>>
>>>> Blue Swirl wrote:
>>>>> On 6/14/09, Jan Kiszka <address@hidden> wrote:
>>>>>> [ I can't check the situation with cygwin, so this is mingw-only. ]
>>>>>>
>>>>>> gcc still does not support the Windows-specific format string modifier
>>>>>> "I64". Therefore, it makes no sense to check for format string
>>>>>> correctness and generate tons of false positives.
>>>>> I don't have this problem, currently mingw builds with zero warnings
>>>>> for me. But I didn't enable automatic -Werror flag for mingw just
>>>>> because I guessed this would happen. What's the gcc version you're
>>>>> using?
>>>> i686-pc-mingw32-gcc (GCC) 4.3.3
>>> 4.3.3 is known to show this bad behavior. AFAICT it is fixed in 4.4.0.
>>> (At least it fixed things for msysGit.)
>>>
>>> FWIW by "bad behavior" I mean that a compiler warning is emitted when
>>> using %I64, but not when using %ll. But when executing the program, it
>>> actually _requires_ a %I64, _not_ a %ll.
>>>
>>> In light of this, I _strongly_ recommend updating to 4.4.0.
>> I will, once I come across a pre-built one that fits.
>
> The de-facto standard is http://www.tdragon.net/recentgcc/
This is pre-built, but for an uninteresting host platform (also known as
Windows). :)
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH] mingw: Do not perform string format checks, Jan Kiszka, 2009/06/14
- Re: [Qemu-devel] [PATCH] mingw: Do not perform string format checks, Blue Swirl, 2009/06/14
- Re: [Qemu-devel] [PATCH] mingw: Do not perform string format checks, Jan Kiszka, 2009/06/14
- Re: [Qemu-devel] [PATCH] mingw: Do not perform string format checks, Johannes Schindelin, 2009/06/14
- Re: [Qemu-devel] [PATCH] mingw: Do not perform string format checks, Jan Kiszka, 2009/06/15
- Re: [Qemu-devel] [PATCH] mingw: Do not perform string format checks, Anthony Liguori, 2009/06/15
- Re: [Qemu-devel] [PATCH] mingw: Do not perform string format checks, Johannes Schindelin, 2009/06/15
- Re: [Qemu-devel] [PATCH] mingw: Do not perform string format checks,
Jan Kiszka <=