|
| From: | Gerd Hoffmann |
| Subject: | Re: [Qemu-devel] [PATCH 2/4] Add device tree machine |
| Date: | Thu, 11 Jun 2009 15:33:00 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
A few more comments ...
+static void dt_add_props(DeviceState *dev, void *dt, int offset)
+{
Where do device properties come from? Only the fdt tree? If so, do we need the property lists in the first place? We could get them directly from the fdt tree instead.
+static const DevicePropList i2c_bus_props[] = {
+ {.name = "address", .type = PROP_TYPE_INT},
+ {.name = NULL}
+};
That could go into BusInfo as well. cheers, Gerd
| [Prev in Thread] | Current Thread | [Next in Thread] |