[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 17/17] m68k: add cas
From: |
Andreas Schwab |
Subject: |
[Qemu-devel] Re: [PATCH 17/17] m68k: add cas |
Date: |
Sat, 30 May 2009 15:53:43 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.94 (gnu/linux) |
Laurent Vivier <address@hidden> writes:
> + cmp = DREG(ext, 0);
> + update = DREG(ext, 6);
> + tmp = gen_load(s, opsize, addr, 0);
> + dest = tcg_temp_local_new();
> + tcg_gen_mov_i32(dest, tmp);
> +
> + res = tcg_temp_new();
> + tcg_gen_sub_i32(res, dest, cmp);
> + gen_logic_cc(s, res);
> +
> + l1 = gen_new_label();
> + l2 = gen_new_label();
> +
> + gen_jmpcc(s, 6 /* !Z */, l1);
> + gen_store(s, opsize, addr, update);
This has a bug: addr is used around a jump.
Andreas.
---
>From b87bc72daf28f519017c79615b962c47a1e0492d Mon Sep 17 00:00:00 2001
From: Andreas Schwab <address@hidden>
Date: Sat, 30 May 2009 15:32:20 +0200
Subject: [PATCH] m68k: fix use of temporary around jump
Signed-off-by: Andreas Schwab <address@hidden>
---
target-m68k/translate.c | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/target-m68k/translate.c b/target-m68k/translate.c
index 4372975..9d68b02 100644
--- a/target-m68k/translate.c
+++ b/target-m68k/translate.c
@@ -1382,6 +1382,7 @@ DISAS_INSN(cas)
TCGv tmp;
TCGv cmp;
TCGv update;
+ TCGv taddr;
TCGv addr;
TCGv res;
uint16_t ext;
@@ -1408,17 +1409,19 @@ DISAS_INSN(cas)
ext = lduw_code(s->pc);
s->pc += 2;
- addr = gen_lea(s, insn, opsize);
- if (IS_NULL_QREG(addr)) {
+ taddr = gen_lea(s, insn, opsize);
+ if (IS_NULL_QREG(taddr)) {
gen_addr_fault(s);
return;
}
cmp = DREG(ext, 0);
update = DREG(ext, 6);
- tmp = gen_load(s, opsize, addr, 0);
+ tmp = gen_load(s, opsize, taddr, 0);
dest = tcg_temp_local_new();
tcg_gen_mov_i32(dest, tmp);
+ addr = tcg_temp_local_new ();
+ tcg_gen_mov_i32(addr, taddr);
res = tcg_temp_new();
tcg_gen_sub_i32(res, dest, cmp);
@@ -1434,6 +1437,7 @@ DISAS_INSN(cas)
tcg_gen_mov_i32(cmp, dest);
gen_set_label(l2);
tcg_temp_free(dest);
+ tcg_temp_free(addr);
}
DISAS_INSN(byterev)
--
1.6.3.1
--
Andreas Schwab, address@hidden
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
- [Qemu-devel] [PATCH 08/17] m68k: modify movem instruction to manage word, (continued)
- [Qemu-devel] [PATCH 08/17] m68k: modify movem instruction to manage word, Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 09/17] m68k: add 64bit divide., Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 10/17] m68k: add 32bit and 64bit multiply, Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 11/17] m68k: add word data size for suba/adda, Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 12/17] m68k: add fpu, Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 13/17] m68k: add "byte", "word" and memory shift, Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 14/17] m68k: add "byte", "word" and memory rotate., Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 15/17] m68k: add bitfield_mem, bitfield_reg, Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 16/17] m68k: add variable offset/width to bitfield_reg/bitfield_mem, Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 17/17] m68k: add cas, Laurent Vivier, 2009/05/29
- [Qemu-devel] Re: [PATCH 17/17] m68k: add cas,
Andreas Schwab <=
- Re: [Qemu-devel] Re: [PATCH 17/17] m68k: add cas, Laurent Vivier, 2009/05/30
- [Qemu-devel] Re: [PATCH 07/17] m68k: add DBcc instruction., Andreas Schwab, 2009/05/30
- [Qemu-devel] Re: [PATCH 07/17] m68k: add DBcc instruction., Laurent Vivier, 2009/05/30
- Re: [Qemu-devel] [PATCH 04/17] m68k: add missing accessing modes for some instructions., Stuart Brady, 2009/05/30
- Re: [Qemu-devel] [PATCH 04/17] m68k: add missing accessing modes for some instructions., Laurent Vivier, 2009/05/31
Re: [Qemu-devel] [PATCH 00/17] m68k: add partial Motorola 680x0 support, François Revol, 2009/05/30