qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp pa


From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel
Date: Fri, 29 May 2009 16:36:25 +0100
User-agent: KMail/1.11.2 (Linux/2.6.29-2-amd64; KDE/4.2.2; x86_64; ; )

> > It still won't work. You can't assume PATH_MAX is defined at all.
>
> You are right, one cannot always assume its there, but we already do:
>
> block.c:    char tmp_filename[PATH_MAX];
> block.c:    char backing_filename[PATH_MAX];
> qemu-char.c:    char pty_name[PATH_MAX];

I consider these to be bugs, with the possible exception of qemu-char.c which 
appears to be part of an OpenBSD workaround.

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]