[Qemu-devel] Re: [PATCH 0/2] Add serial number support for virtio_blk, V2

[john cooper]

Christoph Hellwig wrote:
> On Mon, May 18, 2009 at 11:00:41AM -0400, john cooper wrote:
> > Christoph Hellwig wrote:
> > > So why can't we re-use the existing interfaces instead of inventing a
> > > new one?
> > I'm unclear to what specifically you're referring -- the
> > ioctl() used to retrieve the serial number in the guest?
>
> Well, there's not specific ioctl to get a serial number for scsi, but
> given that we now have SG_IO passthrough in virtio-blk it should be easy
> enough to provide inquiry data and the device identification VPD page
> by that way.  Not sure how it's handled for ide, maybe that way
> is even easier.

Yea, I'm hardly in enamored with the IDE/ATA
diatribe.  But in this case displacing the new
ioctl with HDIO_GET_IDENTITY seemed the most
straightforward means to provide access within
an existing interface.  Updated patch follows.

-john


--
address@hidden