Re: [Qemu-devel] Patch: Adding ability for qemu-img to create SCSI VMware disk images

[Anthony Liguori]

Kevin Wolf wrote:
> Anthony Liguori schrieb:
>   
> > Aaron Mason wrote:
> >     
> > > Who said the images had to be used for QEMU?  As I said, I use the 
> > > utility primarily for creating VMware images. 
> > >       
> > If it's not useful for QEMU, then I don't see that it's worth 
> > maintaining within QEMU.
> >     
>
> Then I wonder why we have the compat6 option for VMDK. I would be rather
> surprised if it was useful for qemu itself.
>   

Yup.  I don't like the compat6 patch either as it's pretty invasive.

> FWIW, I know that SUSE had a use for these SCSI VMDKs and they carry a
> local patch for it. I would prefer to have such things upstream, even if
> it's just for exporting. After all, qemu-img is the Swiss army knife for
> images.
>   

If there's support for it, we can take it.  I worry about adding 
features that aren't widely useful as they add complexity and make it 
hard to refactor things.

Introducing BLOCK_FLAG_BUSLOGIC and BLOCK_FLAG_LSILOGIC seems very wrong 
to me.  You're happy with it?

Regards,

Anthony Liguori
> Kevin
>