[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] qemu: fix pci_find_capability for multiple caps
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PATCH] qemu: fix pci_find_capability for multiple caps |
Date: |
Tue, 26 May 2009 12:30:27 +0300 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
pci_find_capability_list has a bug so it'd stop at the first
capability. This only happens to work as we only support
a single capability (MSI-X). Here's a fix.
Found-by: Isaku Yamahata <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
This is a fixup for my patch "qemu: add routines to manage PCI
capabilities".
hw/pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 19905b9..a63d988 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -918,7 +918,7 @@ static uint8_t pci_find_capability_list(PCIDevice *pdev,
uint8_t cap_id,
for (prev = PCI_CAPABILITY_LIST; (next = pdev->config[prev]);
prev = next + PCI_CAP_LIST_NEXT)
- if (pdev->config[next + PCI_CAP_LIST_ID] != cap_id)
+ if (pdev->config[next + PCI_CAP_LIST_ID] == cap_id)
break;
*prev_p = prev;
--
MST