|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [PATCH] fully split aio_pool from BlockDriver |
Date: | Mon, 25 May 2009 13:58:10 +0300 |
User-agent: | Thunderbird 2.0.0.21 (X11/20090320) |
Christoph Hellwig wrote:
Now that we have a separate aio pool structure we can remove those aio pool details from BlockDriver. Every driver supporting AIO now needs to declare a static AIOPool with the aiocb size and the cancellation method. This cleans up the current code considerably and will make it cleaner and more obvious to support two different aio implementations behind a single BlockDriver.
Looks good.
+static void curl_aio_cancel(BlockDriverAIOCB *blockacb)+{ + // Do we have to implement canceling? Seems to work without... +} +
We do, but I'd rather not think exactly what to do here. I'd like aio cancellation to be asynchronous so things like controller resets don't stall the vcpu.
-- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |