Re: [Qemu-devel] Re: [COMMIT e20a8df] Compile fdc, escc and SCSI controllers only once

[Blue Swirl]

On 5/22/09, Paul Brook <address@hidden> wrote:
>
>  > >  This breaks archs that do not come with DMA_* implementations. At least
>  > >  ARM no longer links.
>  > >
>  > >   LINK  arm-softmmu/qemu-system-arm
>  > >  ../libhw64/libqemuhw64.a(fdc.o): In function `fdctrl_stop_transfer':
>  > >  /data/qemu/hw/fdc.c:1086: undefined reference to `DMA_release_DREQ'
>  > >  [...]
>  >
>  > Yes, I forgot about the whole-archive hack. I've disabled it for
>  > hwlib, so now arm-softmmu links.
>
>
> This is completely wrong. The reason we use whole-archive is so that device
>  constructors are run. Most machines are broken after your change.

Did you test? I don't see any breakage, qemu-img --help shows all
block formats and qemu-system-arm -M '?' lists all machines.

Because whole-archive is still used for libqemu_common.a, all devices
in that archive are linked in (whether they are used or not!), so the
constructors work.