Re: [Qemu-devel] Re: [PATCH 1/4] Add GPL bios as a submodule

[Anthony Liguori]

Avi Kivity wrote:
> Anthony Liguori wrote:
> > > I don't understand the question.  The relative path is set up once 
> > > (in .gitmodules), and that's it.
> >
> > To clone kvm-kvm.git, you have to do:
> >
> > [1] git clone git://git.kernel.org/pub/scm/virt/kvm/kvm-kmod.git
> > [2] git clone git://git.kernel.org/pub/scm/virt/kvm/kvm.git
> > [3] cd kvm-kmod.git
> > [4] git submodule update --init
> >
> > For qemu.git, we'll have to repeat [2] for every ROM we include which 
> > will at least be 6 different repositories.  Contrast that to my 
> > patchset where there's always 3 steps regardless of how many ROMs we 
> > include.
>
> Step 2 is unneeded.  Step 4 takes care of the cloning.  The relative 
> path is relative to the repository you cloned kvm-kmod.git _from_.

Oh, excellent.  Except that's a pain with qemu hosted on Savannah as I 
cannot create additional trees without creating new projects :-(

I can't move qemu's git tree off of Savannah without leaving Savannah 
completely.

> > > Let's only include seabios then and reject all patches to the bochs 
> > > bios.  If that doesn't motivate people to switch, nothing will.
> >
> > I don't think it would be wise to switch the default to seabios until 
> > after 0.11.  I'm concerned that there hasn't been enough testing on 
> > non-mainstream guests.  I'd like a full release cycle worth of testing.
>
> Agreed.

We can put seabios in the tree now (once we work out the rom building 
stuff).  We can get started with testing now and then for the 0.12 tree, 
we'll switch to seabios by default if things don't look like they're 
going to be too painful.

Regards,

Anthony Liguori