qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms


From: Paul Brook
Subject: Re: [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms
Date: Sun, 17 May 2009 23:04:19 +0100
User-agent: KMail/1.11.2 (Linux/2.6.29-2-amd64; KDE/4.2.2; x86_64; ; )

> >> We build the roms in a sub directory of the target build directory.
> >> This is
> >> anticipating a single source base (like uboot) that gets built
> >> differently for
> >> multiple target architectures (PPC, SH4, etc.).

I'm pretty sure this is going to be wrong. i386 and x86-64 use the same rom, 
and uboot will most likely need to be built for every *bard*

> >> +#  Per architecture ROMS
> >> +ROMS=
> >> +ifeq ($(TARGET_BASE_ARCH),i386)
> >> +ROMS+=gplbios vgabios
> >> +endif
> >> +
> >
> > ROMS-i386 = gplbios vgabios
> > ROMS = $(ROMS-$(TARGET_BASE_ARCH))
> >
> > (make is not shell, it tolerates spaces around the equals sign)
>
> Yeah, this is still very rough.  The build/install process is different
> for each rom so I'm probably going to need to do something fancier than
> what I have about.  Perhaps something along a subdir-% rule for the sane
> ROMs that can be overridden for weirder ones.
>
> gplbios and vgabios are simple to build so it's where I started.

This worries me. You've probably picked the easiest examples, and already it 
doesn't fit nicely.

Why are you trying so hard to integrate these into qemu? IMHO they really 
don't belong there. AFAICS the roms share no significant code with qemu, and 
require a completely different environment to build. Especially in cross 
environments I'd expect combining the two to cause much more pain than it's 
worth. When developing/building roms a native environment is the exception 
rather than the norm. Even then it's not really a native build, it's more a 
collection of hacks that allow you get away with using a native toolchain.

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]