qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT aae9460] Basic qdev infrastr


From: Paul Brook
Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT aae9460] Basic qdev infrastructure.
Date: Sun, 17 May 2009 14:57:28 +0100
User-agent: KMail/1.11.2 (Linux/2.6.29-2-amd64; KDE/4.2.2; x86_64; ; )

> >  +struct DeviceProperty {
> >  +        int i;
>
> qdev_set_prop_int uses also 'int' but qdev_get_prop_int returns uint64_t.

Fixed.

> >  +struct DeviceType {
> >  +    int size;
>
> size_t size?

Technically yes. However if we ever get devices with >2G of internal state we 
have much bigger problems :-)

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]