[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: pci_default_config_write() clean up.
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] Re: pci_default_config_write() clean up. |
Date: |
Thu, 7 May 2009 12:57:03 +0100 |
User-agent: |
KMail/1.9.9 |
On Thursday 07 May 2009, Michael S. Tsirkin wrote:
> On Thu, May 07, 2009 at 08:13:51PM +0900, Isaku Yamahata wrote:
> > On Thu, May 07, 2009 at 01:25:38PM +0300, Michael S. Tsirkin wrote:
> > > > How about callback?
> > >
> > > Yes, I think callbacks have the potential to simplify code.
> > > Would you like to add them on top of my patch then?
> >
> > Okay.
> >
> > > - There's some tricky code there to trigger callbacks only once
> > > on a multibyte transaction. It would be simpler just to have
> > > per-dword callbacks. These could get the mask of the written-to bytes
> > > and do if (written_mask & interesting_mask)
> > > stuff
> >
> > Are you assuming that word/dword io port access is word/dword aligned?
>
> I think this does not have to be the case in I/O generally.
You can assume all accesses are naturally aligned. The softmmu code will split
unaligned accesses before devices see them.
Paul