Re: [Qemu-devel] [PATCH] Revived GUEST_BASE support for usermode emulation targets [v3]

[Paul Brook]

On Tuesday 05 May 2009, Riku Voipio wrote:
> +++ b/tcg/x86_64/tcg-target.c
> @@ -616,15 +616,15 @@ static void tcg_out_qemu_ld(TCGContext *s, const
>          /* movzbl */
> -        tcg_out_modrm_offset(s, 0xb6 | P_EXT, data_reg, r0, 0);
> +        tcg_out_modrm_offset(s, 0xb6 | P_EXT, data_reg, r0, GUEST_BASE);

This breaks when GUEST_BASE is large.
32-bit x86 is probably ok because GUEST_BASE is always a 32-bit value. This is 
not true for x86-64. Incidentally tcg_out_modrm doesn't seem to check this, 
and silently generates broken code.

Paul