[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] Rework -boot option
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] Rework -boot option |
Date: |
Mon, 20 Apr 2009 19:38:21 +0100 |
User-agent: |
Mutt/1.4.1i |
On Mon, Apr 20, 2009 at 01:04:48PM -0500, Anthony Liguori wrote:
> Jan Kiszka wrote:
> >This patch changes the boot command line option to the canonical format
> >
> > -boot [order=drives][,interactive=on|off]
> >
> >where 'drives' is using the same format as the old -boot. The new format
> >is required in order to add the 'interactive' option and use the
> >existing infrastructure to parse it.
> >
> >The state of 'interactive' is transfered to the firmware via the new
> >configuration value FW_CFG_BOOT_INTERACTIVE.
> >
> >Signed-off-by: Jan Kiszka <address@hidden>
> >
>
> This breaks compatibility with existing management tools. Can't we do:
>
> -boot [order=]drives[,interactive=on|off]
>
> Certainly, -drive introduces a precedence for this type of format.
The 'order=' seems a little overkill - just leave it out entirely,
just having:
-boot drives,interactive=on|off
which is fully back-compatible too.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|