[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v2 03/11] net: Prevent multiple slirp instances
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH v2 03/11] net: Prevent multiple slirp instances |
Date: |
Sun, 19 Apr 2009 13:51:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Blue Swirl wrote:
> On 4/19/09, Jan Kiszka <address@hidden> wrote:
>> The slirp stack is full of global variables which prevents instantiating
>> it more than once. Catch this during net_slirp_init to prevent more harm
>> later on.
>
> Alternatively the slirp stack could be taught to support multiple instances:
> http://lists.gnu.org/archive/html/qemu-devel/2007-10/msg00470.html
>
For sure - and nice to know that there is a reference! But as your patch
demonstrates, it's a larger effort which comes with some risks of
regression. Therefore I didn't attack this in the first step.
My next to-do item /wrt slirp is making those special IPs and DHCP
ranges fully configurable (ie. dhcpserver=..., gateway=...,
dhcpstart=... etc.). Depending on how many lines I'll have to touch
anyway, I may append multi-instance support to this as well.
In the meantime, and specifically for stable, my patch is required to
catch breakages users can trigger when they do not know about this slirp
limitation.
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/11] Various small networking improvements, Jan Kiszka, 2009/04/19
- [Qemu-devel] [PATCH v2 03/11] net: Prevent multiple slirp instances, Jan Kiszka, 2009/04/19
- [Qemu-devel] [PATCH v2 02/11] net: Check device passed to host_net_remove, Jan Kiszka, 2009/04/19
- [Qemu-devel] [PATCH v2 01/11] net: Fix -net socket,listen, Jan Kiszka, 2009/04/19
- [Qemu-devel] [PATCH v2 07/11] net: Add parameter checks for VLAN clients, Jan Kiszka, 2009/04/19
- [Qemu-devel] [PATCH v2 10/11] slirp: Handle DHCP requests for specific IP, Jan Kiszka, 2009/04/19
- [Qemu-devel] [PATCH v2 06/11] Allow empty params for check_params, Jan Kiszka, 2009/04/19
- [Qemu-devel] [PATCH v2 09/11] net: Add support for capturing VLANs, Jan Kiszka, 2009/04/19
- [Qemu-devel] [PATCH v2 04/11] monitor: Improve host_net_add, Jan Kiszka, 2009/04/19
- [Qemu-devel] [PATCH v2 05/11] monitor: Allow host_net_add/remove for all targets, Jan Kiszka, 2009/04/19