Re: [Qemu-devel] [RFC][PATCH] Rename qemu into qemu-system-i386 and install a compat symlink

[Andreas Färber]

Am 18.04.2009 um 18:01 schrieb Aurelien Jarno:

> For historical reasons, qemu system on i386 is called qemu instead of
> qemu-system-i386. This seems to confuse users.
>
> This patch installs it as qemu-system-i386, and create a compatibility
> symlink qemu -> qemu-system-i386 as some tools may call it that way.
> We can change or remove this symlink after a few releases when all the
> tools have migrated to this new name.
>
> Signed-off-by: Aurelien Jarno <address@hidden>

In general a good idea imo, but don't just assume you can create  
symlinks on a given file system. Git uses hardlinks and copying as  
fallbacks iirc.

Andreas

> ---
> Makefile.target |    7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index dae339b..88c7a32 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -63,12 +63,8 @@ ifdef CONFIG_USER_ONLY
> QEMU_PROG=qemu-$(TARGET_ARCH2)
> else
> # system emulator name
> -ifeq ($(TARGET_ARCH), i386)
> -QEMU_PROG=qemu$(EXESUF)
> -else
> QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
> endif
> -endif
>
> PROGS=$(QEMU_PROG)
>
> @@ -743,6 +739,9 @@ install: all
> ifneq ($(PROGS),)
>         $(INSTALL) -m 755 $(STRIP_OPT) $(PROGS) "$(DESTDIR)$(bindir)"
> endif
> +ifeq ($(TARGET_ARCH), i386)
> +       ln -sf qemu-system-i386$(EXESUF) "$(DESTDIR)$(bindir)/qemu$(EXESUF)"
> +endif
>
> # Include automatically generated dependency files
> -include $(wildcard *.d */*.d)
> --
> 1.6.1.3
>
>
> --
> Aurelien Jarno                          GPG: 1024D/F1BCDB73
> address@hidden                 http://www.aurel32.net