[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix incorrect attempt to clear a flag in vnc.c
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] Fix incorrect attempt to clear a flag in vnc.c |
Date: |
Tue, 7 Apr 2009 21:59:09 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sat, Feb 14, 2009 at 04:20:51PM -0500, Brian Kress wrote:
> Anthony Liguori wrote:
>> Brian Kress wrote:
>>> In vnc.c in pixel_format_message, the code tries to clear the
>>> QEMU_ALLOCATED_FLAG
>>> from the client display surface, however it uses the wrong operator
>>> and ends up enabling all
>>> other flags. Most notably this enables the big endian flag and
>>> causes some chaos.
>> Can you add a Signed-off-by line?
>>
> Signed-off-by: Brian Kress <address@hidden>
Thanks, applied.
> Index: vnc.c
> ===================================================================
> --- vnc.c (revision 6619)
> +++ vnc.c (working copy)
> @@ -1421,7 +1421,7 @@
> else if (vs->ds->surface->pf.bits_per_pixel == 8)
> vs->send_hextile_tile = send_hextile_tile_8;
> vs->clientds = *(vs->ds->surface);
> - vs->clientds.flags |= ~QEMU_ALLOCATED_FLAG;
> + vs->clientds.flags &= ~QEMU_ALLOCATED_FLAG;
> vs->write_pixels = vnc_write_pixels_copy;
>
> vnc_write(vs, pad, 3); /* padding */
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] Fix incorrect attempt to clear a flag in vnc.c,
Aurelien Jarno <=