[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/17] Revived GUEST_BASE support for usermode e
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH 14/17] Revived GUEST_BASE support for usermode emulation targets. |
Date: |
Tue, 31 Mar 2009 21:51:36 +0000 |
User-agent: |
KMail/1.9.9 |
On Tuesday 31 March 2009, address@hidden wrote:
> + "You can use -B option to load target binary into different\n"
> + "address that is specified in elf headers. This can be
> useful\n" + "when target binary would be loaded to low addresses
> and\n" + "/proc/sys/vm/mmap_min_addr is set to higher. For
> example\n" + " qemu-" TARGET_ARCH " -B 0x100000 ...\n"
> + "loads target binary starting from the first meg.\n"
This is wrong. -B is completely transparent to the guest application and
offsets the whole guest address space.
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index c6b0b74..ef2bf55 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -2413,6 +2413,8 @@ static inline abi_long do_shmat(int shmid, abi_ulong
> shmaddr, int shmflg, }
> }
>
> + *raddr = h2g(*raddr);
> +
This is wrong. host and guest addresses are different sizes.
This sort of bugfix should also be separated from the host support. Especially
as the bogus code comes from one of your earlier patches.
Paul
- Re: [Qemu-devel] [PATCH 05/17] Fix and cleanup IPCOP_shm* ipc calls handling, (continued)
- [Qemu-devel] [PATCH 01/17] Fix fstatat64()/newfstatat() syscall implementation, riku . voipio, 2009/03/31
- [Qemu-devel] [PATCH 04/17] Implement sem* syscalls, riku . voipio, 2009/03/31
- [Qemu-devel] [PATCH 02/17] Rewrite mmap_find_vma() to work fine on 64-bit hosts with 32-bit targets, riku . voipio, 2009/03/31
- [Qemu-devel] [PATCH 15/17] linux-user: removed unnecessary MAX_SOCK_ADDR checks for socket syscalls, riku . voipio, 2009/03/31
- [Qemu-devel] [PATCH 08/17] Added posix message queue syscalls except mq_notify, riku . voipio, 2009/03/31
- [Qemu-devel] [PATCH 10/17] More strace formatting for posix message queues syscalls, riku . voipio, 2009/03/31
- [Qemu-devel] [PATCH 09/17] Format mq_open strace arguments, riku . voipio, 2009/03/31
- [Qemu-devel] [PATCH 11/17] Add support for passing contents of argv0, riku . voipio, 2009/03/31
- [Qemu-devel] [PATCH 14/17] Revived GUEST_BASE support for usermode emulation targets., riku . voipio, 2009/03/31
- Re: [Qemu-devel] [PATCH 14/17] Revived GUEST_BASE support for usermode emulation targets.,
Paul Brook <=
- [Qemu-devel] [PATCH 16/17] Prefer glibc over direct syscalls, riku . voipio, 2009/03/31
- [Qemu-devel] [PATCH 17/17] linux-user: Proper exit code for uncaught signals, riku . voipio, 2009/03/31
- [Qemu-devel] [PATCH 07/17] shmat(): use mmap_find_vma to find free memory area, riku . voipio, 2009/03/31
- [Qemu-devel] [PATCH 03/17] Fix and cleanup IPCOP_sem* ipc calls handling, riku . voipio, 2009/03/31
- [Qemu-devel] [PATCH 12/17] linux-user: unix sockets - fix running dbus, riku . voipio, 2009/03/31
- [Qemu-devel] [PATCH 06/17] Implement shm* syscalls, riku . voipio, 2009/03/31
- [Qemu-devel] [PATCH 13/17] Strace is now working again with GUEST_BASE support., riku . voipio, 2009/03/31
- Re: [Qemu-devel] [PATCH 00/17] linux-user patches in maemo, Paul Brook, 2009/03/31